Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add Ruby 3.2 #283

Merged
merged 3 commits into from
May 16, 2023
Merged

CI: Add Ruby 3.2 #283

merged 3 commits into from
May 16, 2023

Conversation

arturoherrero
Copy link
Contributor

Description

Add Ruby 3.2 CI support.

@arturoherrero
Copy link
Contributor Author

Hi @lfittl, I'm curious to know how far we are in bringing support for Ruby 3.2. I'm creating this to see if we have any CI failures. Thanks!

@arturoherrero
Copy link
Contributor Author

It looks like we have to update the google-protobuf gem to fix the job failure.

google-protobuf-3.21.12-x86_64-linux requires ruby version < 3.2.dev, >= 2.5,
which is incompatible with the current version, 3.2.2

Related to protocolbuffers/protobuf#11578 and protocolbuffers/protobuf#11538.

@arturoherrero
Copy link
Contributor Author

@lfittl I'm not sure if 12d0387 is enough 😉

@arturoherrero
Copy link
Contributor Author

It works! On the other hand, we should drop support of Ruby 2.5 because it's incompatible with the gem update. See the new job failure.

google-protobuf-3.22.3-x86_64-linux requires ruby version < 3.3.dev, >= 2.6,
which is incompatible with the current version, 2.5.9

I think it's okay because Ruby 2.5 End-Of-Life was 2021-04-05 (2 years ago)

Reference: https://www.ruby-lang.org/en/downloads/branches/

@arturoherrero
Copy link
Contributor Author

@lfittl please review my previous message and 284b977. This should be ready now.

@arturoherrero
Copy link
Contributor Author

👋 @lfittl Friendly reminder about this. Thanks!

@lfittl lfittl merged commit f668c57 into pganalyze:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants